Convert Material and CDK to standalone #28155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
crisbeto
added
the
merge: preserve commits
crisbeto
force-pushed
the
standalone
branch
3 times, most recently
from
6eb58a8 to
bf32b8f
Compare
angular-robot
bot
added
the
area: build & ci
angular-robot
bot
removed
the
area: build & ci
crisbeto
force-pushed
the
standalone
branch
4 times, most recently
from
43b379a to
6c4f888
Compare
…ormat Converts test components in the CDK to standalone and fixes some that weren't formatteed according to the Prettier config.
Converts `cdk/a11y` to standalone.
Converts `cdk/accordion` to standalone.
Converts `cdk/bidi` to standalone.
Converts `cdk/clipboard` to standalone.
Converts `cdk/portal` to standalone.
Converts `cdk/stepper` to standalone.
Converts `cdk/table` to standalone.
Converts `cdk/text-field` to standalone.
Converts `cdk/tree` to standalone.
Converts `cdk/observers` to standalone.
Converts `material/autocomplete` to standalone.
Converts `material/badge` to standalone.
Converts `material/bottom-sheet` to standalone.
Converts `material/button` to standalone.
Converts `material/button-toggle` to standalone.
wagnermaciel
approved these changes
Nov 20, 2023
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Nov 21, 2023
During the presubmit of angular/components#28155 an internal check started flagging the `setAttribute` call inside `relativePath`. This code has been here for many years, but I suspect that the import graph changing caused it to be surfaced. Ideally we would refactor this code not to create a DOM node at all, but for now this is the simplest approach to unblock the change in Material.
|
Blocked on angular/angular#53097. |
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Nov 21, 2023
During the presubmit of angular/components#28155 an internal check started flagging the `setAttribute` call inside `relativePath`. This code has been here for many years, but I suspect that the import graph changing caused it to be surfaced. Ideally we would refactor this code not to create a DOM node at all, but for now this is the simplest approach to unblock the change in Material.
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Nov 21, 2023
… path Currently the way we extract the pathname of a URL is by creating an anchor node, assigning the URL to its `href` and reading the `pathname`. This is inefficient and it triggers an internal security check that doesn't allow the `href` attribute to be set which ends up blocking angular/components#28155. These changes switch to using the browser's built-in URL parsing instead.
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Nov 21, 2023
… path Currently the way we extract the pathname of a URL is by creating an anchor node, assigning the URL to its `href` and reading the `pathname`. This is inefficient and it triggers an internal security check that doesn't allow the `href` attribute to be set which ends up blocking angular/components#28155. These changes switch to using the browser's built-in URL parsing instead.
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Nov 21, 2023
… path Currently the way we extract the pathname of a URL is by creating an anchor node, assigning the URL to its `href` and reading the `pathname`. This is inefficient and it triggers an internal security check that doesn't allow the `href` attribute to be set which ends up blocking angular/components#28155. These changes switch to using the browser's built-in URL parsing instead.
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Nov 23, 2023
… path Currently the way we extract the pathname of a URL is by creating an anchor node, assigning the URL to its `href` and reading the `pathname`. This is inefficient and it triggers an internal security check that doesn't allow the `href` attribute to be set which ends up blocking angular/components#28155. These changes switch to using the browser's built-in URL parsing instead.
|
I have a question: Are all material components suitable for conversion to standalone components? I want to know what you think :) |
|
There's nothing stopping you from continuing to use the |
pkozlowski-opensource
pushed a commit
to angular/angular
that referenced
this pull request
Nov 27, 2023
… path (#53097) Currently the way we extract the pathname of a URL is by creating an anchor node, assigning the URL to its `href` and reading the `pathname`. This is inefficient and it triggers an internal security check that doesn't allow the `href` attribute to be set which ends up blocking angular/components#28155. These changes switch to using the browser's built-in URL parsing instead. PR Close #53097
pkozlowski-opensource
pushed a commit
to angular/angular
that referenced
this pull request
Nov 27, 2023
… path (#53097) Currently the way we extract the pathname of a URL is by creating an anchor node, assigning the URL to its `href` and reading the `pathname`. This is inefficient and it triggers an internal security check that doesn't allow the `href` attribute to be set which ends up blocking angular/components#28155. These changes switch to using the browser's built-in URL parsing instead. PR Close #53097
tbondwilkinson
pushed a commit
to tbondwilkinson/angular
that referenced
this pull request
Dec 6, 2023
… path (angular#53097) Currently the way we extract the pathname of a URL is by creating an anchor node, assigning the URL to its `href` and reading the `pathname`. This is inefficient and it triggers an internal security check that doesn't allow the `href` attribute to be set which ends up blocking angular/components#28155. These changes switch to using the browser's built-in URL parsing instead. PR Close angular#53097
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Dec 11, 2023
Cherry-picks some of the changes from angular#28155 to the patch branch since they're necessary for compatibility with `@defer`. Fixes angular#28198.
crisbeto
added a commit
that referenced
this pull request
Dec 11, 2023
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts all of Material and the remaining non-standalone directives in the CDK to standalone. Note that there's more work to be done like fixing up tests and updating public APIs to be more standalone-friendly.