Skip to content

fix(aria/combobox): prevent re-dispatching keyboard event on control target change #33362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ok7sai merged 1 commit into from
Jun 8, 2026
+6 −5
Merged

fix(aria/combobox): prevent re-dispatching keyboard event on control target change #33362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/aria/private/combobox/combobox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,11 +235,12 @@ export class ComboboxPattern {
// Reset isDeleting when the user navigates, so that the highlight effect can run again.
this.isDeleting.set(false);

const popup = untracked(() => this.inputs.popup());
const popupExpanded = untracked(() => this.isExpanded());
if (popupExpanded) {
popup?.controlTarget()?.dispatchEvent(event);
}
untracked(() => {
const popup = this.inputs.popup();
if (this.isExpanded()) {
popup?.controlTarget()?.dispatchEvent(event);
}
});
}

/** Closes the popup when focus leaves the combobox and popup. */
Expand Down
Loading