From 76efcce8582204d78460512459d5f7bd7add7b2e Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Mon, 10 Mar 2025 15:46:34 +0000 Subject: [PATCH 1/2] refactor(github-actions): do not install yarn The user, consuming the action, should be responsible for installing pnpm, or yarn. --- github-actions/setup-wsl/action.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/github-actions/setup-wsl/action.yml b/github-actions/setup-wsl/action.yml index f11581368..e9d4392e6 100644 --- a/github-actions/setup-wsl/action.yml +++ b/github-actions/setup-wsl/action.yml @@ -129,6 +129,3 @@ runs: cd ${{steps.disk_path.outputs.repo}} nvm install shell: wsl-bash {0} - - name: Installing Yarn (in WSL) - run: npm install -g yarn@1 - shell: wsl-bash {0} From efc72b2e06dd22bd5bcaa5548515da8e2ed419c9 Mon Sep 17 00:00:00 2001 From: Paul Gschwendtner Date: Mon, 10 Mar 2025 16:07:33 +0000 Subject: [PATCH 2/2] fix(bazel/spec-bundling): ensure transitive npm sources are available Fixes that spec-bundling wasn't able to bundle when external npm packages were involved. --- bazel/spec-bundling/index_rjs.bzl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/bazel/spec-bundling/index_rjs.bzl b/bazel/spec-bundling/index_rjs.bzl index b3cac78cd..ec23c9632 100644 --- a/bazel/spec-bundling/index_rjs.bzl +++ b/bazel/spec-bundling/index_rjs.bzl @@ -11,7 +11,9 @@ def spec_bundle(name, deps, bootstrap = [], testonly = True, **kwargs): esbuild.esbuild( name = name, - srcs = [ + # Note: `deps` are added here to automatically collect transitive NPM + # sources etc. and make them available for bundling. + srcs = deps + [ ":%s_entrypoint" % name, ], testonly = testonly,