From a47ccd964a7bb6bd1995719c9951bc0237cfb709 Mon Sep 17 00:00:00 2001 From: Doug Parker Date: Tue, 15 Apr 2025 16:12:07 -0700 Subject: [PATCH] refactor(github-actions): add `--noEmit` to lint build Without this, the lint job actually generates a bunch of in-tree `*.js` files. This creates a bunch of noise for developers who blindly copy-past the command to debug an issue and also risks future commands in this job running against those `*.js` files, which likely wouldn't be intended. --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 75ab57caf..fa8cf10d4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -27,7 +27,7 @@ jobs: - uses: ./github-actions/npm/checkout-and-setup-node - run: yarn install --immutable - name: Confirm code builds with typescript as expected - run: yarn tsc -p tsconfig.json + run: yarn tsc -p tsconfig.json --noEmit test: timeout-minutes: 15