From 6f4dbf628cc641f6243f3a0211cf3561266199b8 Mon Sep 17 00:00:00 2001 From: Joey Perrott Date: Fri, 22 Aug 2025 19:05:31 +0000 Subject: [PATCH] fix(bazel): include package.json for api_golden_test_npm_package runs to ensure it runs in commonjs --- bazel/api-golden/BUILD.bazel | 1 + bazel/api-golden/api_golden_test_npm_package.bzl | 11 ++++++++++- bazel/api-golden/package.json | 3 +++ 3 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 bazel/api-golden/package.json diff --git a/bazel/api-golden/BUILD.bazel b/bazel/api-golden/BUILD.bazel index 32e1529b7..184555a9b 100644 --- a/bazel/api-golden/BUILD.bazel +++ b/bazel/api-golden/BUILD.bazel @@ -5,6 +5,7 @@ package(default_visibility = ["//visibility:public"]) exports_files([ "index.ts", "index_npm_packages.cts", + "package.json", ]) ts_project( diff --git a/bazel/api-golden/api_golden_test_npm_package.bzl b/bazel/api-golden/api_golden_test_npm_package.bzl index 74744c69a..6bc5be818 100644 --- a/bazel/api-golden/api_golden_test_npm_package.bzl +++ b/bazel/api-golden/api_golden_test_npm_package.bzl @@ -30,7 +30,10 @@ def api_golden_test_npm_package( kwargs["tags"] = kwargs.get("tags", []) + ["api_guard"] - data.append("@devinfra//bazel/api-golden") + data.extend([ + "@devinfra//bazel/api-golden", + "@devinfra//bazel/api-golden:package.json", + ]) types_name_and_path = [] for label, n in types.items(): @@ -46,6 +49,9 @@ def api_golden_test_npm_package( name = name, data = data, entry_point = "@devinfra//bazel/api-golden:index_npm_packages.cjs", + no_copy_to_bin = [ + "@devinfra//bazel/api-golden:package.json", + ], args = [golden_dir, npm_package, "false", quoted_export_pattern] + types_name_and_path, **kwargs ) @@ -54,6 +60,9 @@ def api_golden_test_npm_package( name = name + ".accept", testonly = True, data = data, + no_copy_to_bin = [ + "@devinfra//bazel/api-golden:package.json", + ], entry_point = "@devinfra//bazel/api-golden:index_npm_packages.cjs", args = [golden_dir, npm_package, "true", quoted_export_pattern] + types_name_and_path, **kwargs diff --git a/bazel/api-golden/package.json b/bazel/api-golden/package.json new file mode 100644 index 000000000..5bbefffba --- /dev/null +++ b/bazel/api-golden/package.json @@ -0,0 +1,3 @@ +{ + "type": "commonjs" +}