bug(ConsoleReporter): fix a bug in the console reporter where no options were passed #4

Merged
merged 1 commit into from Mar 12, 2014

2 participants

@iammerrick

Some of these things, it seems non-sensible to do a pull request... The real request here is this.... Will you trust me @IgorMinar?

@iammerrick iammerrick added cla: yes and removed cla: no labels Mar 8, 2014
@IgorMinar
Angular member

in commit message: bug -> fix

I will trust you, but let's get a few PRs in with a review first. All of my PRs are reviewed by someone else. Code reviews are not about distrust, but about sharing and learning.

@IgorMinar
Angular member

Can you write a test for this please?

Otherwise LGTM

@iammerrick

Lesson learned, what a terrible time to actually not have a spec. :-P Alright changes the wording and squashed the commits in a new one.

@IgorMinar
Angular member

Lgtm

@iammerrick iammerrick merged commit 0fa7d0d into master Mar 12, 2014

1 check passed

Details default The Travis CI build passed
@iammerrick iammerrick deleted the bug/defaults branch Mar 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment