New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add responsive support for ngClass and ngStyle #170

Merged
merged 3 commits into from Feb 9, 2017

Conversation

Projects
None yet
5 participants
@joanllenas
Collaborator

joanllenas commented Feb 8, 2017

@ThomasBurleson - The new PR is ready for reviewing

@joanllenas

This comment has been minimized.

Collaborator

joanllenas commented Feb 8, 2017

btw, I figured out what the issues were, hence the passing build.
I messed up my commits in the previous PR, and I couldn't even find what was wrong...

@ThomasBurleson

This comment has been minimized.

Collaborator

ThomasBurleson commented Feb 8, 2017

@joanllenas - Let me add some unit tests and this will be a GREAT addition to the library. Nice work sir!

@joanllenas

This comment has been minimized.

Collaborator

joanllenas commented Feb 8, 2017

@ThomasBurleson - perfect! thanks for your time and guidance.

@ThomasBurleson

This comment has been minimized.

Collaborator

ThomasBurleson commented Feb 8, 2017

@joanllenas - great addition to this library. Thx again.

@googlebot

This comment has been minimized.

Collaborator

googlebot commented Feb 8, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

joanllenas and others added some commits Feb 8, 2017

@googlebot googlebot added the cla: no label Feb 9, 2017

@tinayuangao tinayuangao merged commit f57a63d into master Feb 9, 2017

1 of 2 checks passed

cla/google CLAs are signed, but unable to verify author consent
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@d3viant0ne

This comment has been minimized.

Contributor

d3viant0ne commented Feb 9, 2017

@joanllenas - Playing with this in one of my projects now, great addition.

@joanllenas

This comment has been minimized.

Collaborator

joanllenas commented Feb 9, 2017

Thanks, @d3viant0ne :)

@ThomasBurleson ThomasBurleson deleted the feat/responsive-class-style branch Feb 9, 2017

karlhaas added a commit to karlhaas/flex-layout that referenced this pull request May 3, 2017

feat(api): add responsive support for ngClass and ngStyle (angular#170)
* update(flexbox): refactor fxStyle and fxClass code

*  refactor code to `base-adapter.ts`

* update(flexbox): refactor fxStyle and fxClass code

*  refactor code to `base-adapter.ts`

* feat(api): add responsive support for ngClass and ngStyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment