Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add responsive support for ngClass and ngStyle #170

Merged
merged 3 commits into from Feb 9, 2017

Conversation

joanllenas
Copy link
Contributor

@joanllenas joanllenas commented Feb 8, 2017

@ThomasBurleson - The new PR is ready for reviewing

@joanllenas
Copy link
Contributor Author

joanllenas commented Feb 8, 2017

btw, I figured out what the issues were, hence the passing build.
I messed up my commits in the previous PR, and I couldn't even find what was wrong...

@ThomasBurleson
Copy link
Contributor

ThomasBurleson commented Feb 8, 2017

@joanllenas - Let me add some unit tests and this will be a GREAT addition to the library. Nice work sir!

@joanllenas
Copy link
Contributor Author

joanllenas commented Feb 8, 2017

@ThomasBurleson - perfect! thanks for your time and guidance.

@ThomasBurleson ThomasBurleson added pr: lgtm This PR has been approved by the reviewer pr: needs presubmit labels Feb 8, 2017
@ThomasBurleson
Copy link
Contributor

ThomasBurleson commented Feb 8, 2017

@joanllenas - great addition to this library. Thx again.

@googlebot
Copy link
Collaborator

googlebot commented Feb 8, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ and removed cla: yes labels Feb 8, 2017
@ThomasBurleson ThomasBurleson removed pr: needs rebase cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ labels Feb 8, 2017
@ThomasBurleson ThomasBurleson force-pushed the feat/responsive-class-style branch from 7db4a29 to dedd1cb Compare Feb 9, 2017
@googlebot googlebot added the cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ label Feb 9, 2017
@tinayuangao tinayuangao merged commit f57a63d into master Feb 9, 2017
@joshwiens
Copy link
Contributor

joshwiens commented Feb 9, 2017

@joanllenas - Playing with this in one of my projects now, great addition.

@joanllenas
Copy link
Contributor Author

joanllenas commented Feb 9, 2017

Thanks, @d3viant0ne :)

@ThomasBurleson ThomasBurleson deleted the feat/responsive-class-style branch Feb 9, 2017
karlhaas pushed a commit to karlhaas/flex-layout that referenced this pull request May 3, 2017
* update(flexbox): refactor fxStyle and fxClass code

*  refactor code to `base-adapter.ts`

* update(flexbox): refactor fxStyle and fxClass code

*  refactor code to `base-adapter.ts`

* feat(api): add responsive support for ngClass and ngStyle
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 5, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: no PR author needs to sign Google's CLA: https://opensource.google.com/docs/cla/ pr: lgtm This PR has been approved by the reviewer pr: needs presubmit pr: needs rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants