From 8b210c38b72fe9757fb6379408a371c96870a371 Mon Sep 17 00:00:00 2001 From: Thomas Burleson Date: Sat, 5 Sep 2015 14:24:54 -0500 Subject: [PATCH] fix(layout): device size attributes should not set max-width or max-height do not specify max-height or max-width for **.layout-column** and **.layout-row** media breakpoints; as these incorrectly limited the size of the container. > Consider below where `` is the display breakpoints sm, md, lg, gt-sm, etc. Breaking Changes Before ```css .layout-colum > .flex- { max-height : ; } .layout-row > .flex- { max-width : ; } ``` now ```css .layout-colum > .flex- { } .layout-row > .flex- { } ``` --- src/core/services/layout/layout.scss | 29 +++++++++------------------- 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/src/core/services/layout/layout.scss b/src/core/services/layout/layout.scss index 63344ea129c..aafa8062630 100644 --- a/src/core/services/layout/layout.scss +++ b/src/core/services/layout/layout.scss @@ -157,36 +157,25 @@ .#{$flexName}-#{$i * 5} { flex: 0 0 #{$i * 5 + '%'}; } - .layout-row > .#{$flexName}-#{$i * 5} { - max-width: #{$i * 5 + '%'}; - } - .layout-column > .#{$flexName}-#{$i * 5} { - max-height: #{$i * 5 + '%'}; - } + .layout-row > .#{$flexName}-#{$i * 5} { } + .layout-column > .#{$flexName}-#{$i * 5} { } } .#{$flexName}-33, .#{$flexName}-34 { - flex: 0 0 33.33%; + flex: 0 0 34%; } .#{$flexName}-66, .#{$flexName}-67 { - flex: 0 0 66.66%; + flex: 0 0 66%; + } .layout-row { - > .#{$flexName}-33, > .#{$flexName}-34 { - max-width: 33.33%; - } - > .#{$flexName}-66, > .#{$flexName}-67 { - max-width: 66.66%; - } + > .#{$flexName}-33, > .#{$flexName}-34 { } + > .#{$flexName}-66, > .#{$flexName}-67 { } } .layout-column { - > .#{$flexName}-33, > .#{$flexName}-34 { - max-height: 33.33%; - } - > .#{$flexName}-66, > .#{$flexName}-67 { - max-height: 66.66%; - } + > .#{$flexName}-33, > .#{$flexName}-34 { } + > .#{$flexName}-66, > .#{$flexName}-67 { } } }