This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
refactor(): add -gt- attrs, switch back to sm/md/lg
BREAKING CHANGE: the -phone, -tablet, -pc, and -tablet-landscape attribute suffixes have been removed and replaced with -sm, -md, and -lg attributes. * hide-sm means hide only on small devices (phones). * hide-md means hide only on medium devices (tablets) * hide-lg means hide only on large devices (rotated tablets). Additionally, three new attribute suffixes have been provided for more flexibility: * hide-gt-sm means hide on devices with size greater than small (bigger than phones). * hide-gt-md means hide on devices with size greater than medium (bigger than tablets) * hide-gt-lg means hide on devices with size greater than large (bigger than rotated tablets). See the [layout options section](http://material.angularjs.org/#/layout/options) of the website for more up-to-date information.
- Loading branch information
Showing
31 changed files
with
662 additions
and
653 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
a659c54
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gkalpak thanks for the feedback. Most of it has been implemented in master.
Also, regarding your review of the coding guidelines docs earlier: I caught some of what you caught before merging it into master, but not all of it. If you opened a PR fixing the other doc problems, that'd be awesome!
a659c54
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gkalpak 0412152
a659c54
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajoslin: Sorry, to spam you with all the comments :)
So, it's not clear to me: Does 0412152 take care of everything, or are there still things I could fix and submit a PR ?
a659c54
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you submit a PR for things in docs/guides/ that you commented on earlier?
a659c54
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And don't be sorry. I greatly appreciate your feedback. So far, almost all of your comments have been logical and right.
a659c54
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, I see. Sure, I will submit a PR for docs/guide/.
Actually, I wasn't done reviewing this one, so I will leave a couple more quick comments here as reminders for me to submit a PR later (or tomorrow). So, don't bother with my new comments (and sorry to polute your commit 😃).
a659c54
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ajoslin: I submitted a PR with a couple more minor fixes (#765).
Regarding my comments on docs/guides/ (#750), I submitted a PR against the
wip-guidelines
branch (#768).I didn't do anything about #750 (comment).
I don't any reason to call have the
js
folder (but it's up to you guys).