Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Required asterisk on md-select #7928

Closed
corentin-gautier opened this issue Apr 7, 2016 · 7 comments
Closed

Required asterisk on md-select #7928

corentin-gautier opened this issue Apr 7, 2016 · 7 comments
Assignees
@devversion
Labels
has: Pull Request A PR has been created to address this issue resolution: fixed type: enhancement
Milestone
1.1.0

Comments

@corentin-gautier
Copy link

@devversion As mentioned in #6647 it would be great to have the same required asterisks on md-select as for normal input.
@devversion
Copy link
Member

Yes, this will be an easy fix, but at first we need to confirm with the Specs, did you find anything in the specs yet, which shows a required asterisk on the select label?

@devversion devversion self-assigned this Apr 7, 2016
@corentin-gautier
Copy link
Author

@devversion I don't think I ever saw it in the specs but IMO that would not be very coherent to have a form with required inputs with asterisks and required select without.

@devversion
Copy link
Member

@corentin-gautier I agree with you. @ThomasBurleson what do you think?

@devversion devversion added the needs: feedback The issue creator or community need to respond to questions in this issue label Apr 9, 2016
@ThomasBurleson ThomasBurleson modified the milestone: Backlog Apr 20, 2016
@manuelagard
Copy link

+1

@djmarquette
Copy link

We are manually adding the asterisk to our required select fields to maintain consistency with our required input fields. It's ugly, and await a better solution. Thanks.

@devversion devversion added type: enhancement and removed needs: feedback The issue creator or community need to respond to questions in this issue labels May 3, 2016
devversion added a commit to devversion/material that referenced this issue May 5, 2016
@devversion
feat(select): support asterisk on floating labels.
fbc50c3 
* This adds support for asterisks on the select's floating labels.
* Also adds a description to the input and select documentation.

Closes angular#7928.
@devversion devversion added the has: Pull Request A PR has been created to address this issue label May 5, 2016
devversion added a commit to devversion/material that referenced this issue May 5, 2016
@devversion
feat(select): support asterisk on floating labels.
c0a7891 
* This adds support for asterisks on the select's floating labels.
* Also adds a description to the input and select documentation.

Closes angular#7928.
@devversion devversion mentioned this issue May 5, 2016
Closed
@vlichtenberg
Copy link

I'm still getting an issue here, and I suspect that it's because containerCtrl.label can't be evaluated here. When I put this block into a function and then execute it when the class processes, it does work (same as the setupAttributeWatchers method in inputTextareaDirective).

@Splaktar Splaktar modified the milestones: - Backlog, 1.1.0 Jan 28, 2019
@Splaktar
Copy link
Member

@vlichtenberg can you please open a new issue with a CodePen demo and reproduction steps? Please mention this issue as being related in the description.

@angular angular locked as resolved and limited conversation to collaborators Jan 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
has: Pull Request A PR has been created to address this issue resolution: fixed type: enhancement
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
7 participants
@ThomasBurleson @vlichtenberg @Splaktar @corentin-gautier @devversion @djmarquette @manuelagard