Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

mdPanel: assume that number is in pixels #9604

Closed
crisbeto opened this issue Sep 14, 2016 · 0 comments
Closed

mdPanel: assume that number is in pixels #9604

crisbeto opened this issue Sep 14, 2016 · 0 comments
Assignees
@Splaktar
Labels
has: Pull Request A PR has been created to address this issue P3: important Important issues that really should be fixed when possible. resolution: fixed type: bug
Milestone
1.1.8

Comments

@crisbeto
Copy link
Member

Currently passing in a plain number doesn't work with the withOffsetX and withOffsetY methods, because they only accept CSS units. In this case we should append the px unit automatically.

Referencing #9564.
@crisbeto crisbeto self-assigned this Sep 14, 2016
@crisbeto crisbeto added the has: Pull Request A PR has been created to address this issue label Sep 14, 2016
crisbeto added a commit to crisbeto/material that referenced this issue Sep 14, 2016
@crisbeto
fix(panel): allow numbers in offset methods
1b695cc 
Allows for numbers to be pass to the `withOffsetX` and `withOffsetY` methods, assuming that the units are pixels.

Fixes angular#9604.
@crisbeto crisbeto mentioned this issue Sep 14, 2016
Merged
crisbeto added a commit to crisbeto/material that referenced this issue Sep 15, 2016
@crisbeto
fix(panel): allow numbers in offset methods
628ec9f 
Allows for numbers to be pass to the `withOffsetX` and `withOffsetY` methods, assuming that the units are pixels.

Fixes angular#9604.
crisbeto added a commit to crisbeto/material that referenced this issue Sep 15, 2016
@crisbeto
fix(panel): allow numbers in offset methods
ae7a0d3 
Allows for numbers to be pass to the `withOffsetX` and `withOffsetY` methods, assuming that the units are pixels.

Fixes angular#9604.
@ThomasBurleson ThomasBurleson modified the milestone: 1.1.2 Sep 16, 2016
crisbeto added a commit to crisbeto/material that referenced this issue Sep 21, 2016
@crisbeto
fix(panel): allow numbers in offset methods
b894397 
Allows for numbers to be pass to the `withOffsetX` and `withOffsetY` methods, assuming that the units are pixels.

Fixes angular#9604.
crisbeto added a commit to crisbeto/material that referenced this issue Sep 26, 2016
@crisbeto
fix(panel): allow numbers in offset methods
07a594c 
Allows for numbers to be pass to the `withOffsetX` and `withOffsetY` methods, assuming that the units are pixels.

Fixes angular#9604.
crisbeto added a commit to crisbeto/material that referenced this issue Oct 26, 2016
@crisbeto
fix(panel): allow numbers in offset methods
cfd857e 
Allows for numbers to be pass to the `withOffsetX` and `withOffsetY` methods, assuming that the units are pixels.

Fixes angular#9604.
crisbeto added a commit to crisbeto/material that referenced this issue Oct 26, 2016
@crisbeto
fix(panel): allow numbers in offset methods
abeeb87 
Allows for numbers to be pass to the `withOffsetX` and `withOffsetY` methods, assuming that the units are pixels.

Fixes angular#9604.
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.2, 1.1.4 Feb 4, 2017
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.4, 1.1.5 May 7, 2017
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.5, 1.1.6 Sep 5, 2017
@Splaktar Splaktar modified the milestones: 1.1.6, 1.1.7 Jan 17, 2018
@Splaktar Splaktar self-assigned this Feb 7, 2018
@Splaktar Splaktar added the P3: important Important issues that really should be fixed when possible. label Feb 7, 2018
@Splaktar Splaktar modified the milestones: 1.1.7, 1.1.8 Feb 8, 2018
mmalerba pushed a commit that referenced this issue Feb 9, 2018
@crisbeto @mmalerba
fix(panel): allow numbers in offset methods (#9609)
0d276f3 
Allows for numbers to be pass to the `withOffsetX` and `withOffsetY` methods, assuming that the units are pixels.

Fixes #9604.
chmelevskij pushed a commit to chmelevskij/material that referenced this issue Jun 19, 2018
@crisbeto @chmelevskij
fix(panel): allow numbers in offset methods (angular#9609)
71c1f34 
Allows for numbers to be pass to the `withOffsetX` and `withOffsetY` methods, assuming that the units are pixels.

Fixes angular#9604.
Splaktar pushed a commit that referenced this issue Jul 31, 2018
@crisbeto @Splaktar
fix(panel): allow numbers in offset methods (#9609)
a23b43b 
Allows for numbers to be pass to the `withOffsetX` and `withOffsetY` methods, assuming that the units are pixels.

Fixes #9604.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Splaktar Splaktar

Labels
has: Pull Request A PR has been created to address this issue P3: important Important issues that really should be fixed when possible. resolution: fixed type: bug
Projects
None yet
Milestone
1.1.8
Development

No branches or pull requests
3 participants
@ThomasBurleson @Splaktar @crisbeto