This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
fixes the validation for date picker in IE #10015
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
This looks good, but can you add some unit tests that show how this fixes the failure? |
|
@topherfangio - can you add 1-2 unit tests for this PR? |
ThomasBurleson
added
the
needs: unit tests
ThomasBurleson
removed
the
needs: unit tests
|
Closing as stale PR. |
3 tasks
mmalerba
pushed a commit
that referenced
this pull request
Jan 4, 2019
## PR Checklist Please check that your PR fulfills the following requirements: - [x] The commit message follows [our guidelines](https://github.com/angular/material/blob/master/.github/CONTRIBUTING.md#-commit-message-format) - [x] Tests for the changes have been added (for bug fixes / features) - [x] Docs have been added / updated (for bug fixes / features) ## PR Type What kind of change does this PR introduce? ``` [x] Bugfix [ ] Feature [ ] Code style update (formatting, local variables) [ ] Refactoring (no functional changes, no api changes) [ ] Build related changes [ ] CI related changes [ ] Documentation content changes [ ] Infrastructure changes [ ] Other... Please describe: ``` ## What is the current behavior? this fixes a regression introduced in v1.1.0 against IE however the test is able to reproduce the issue on Chrome Issue Number: Fixes #9994. Closes #10520. Relates to #10015. ## What is the new behavior? The test passes and datepicker validation and ngMessages work properly on IE. ## Does this PR introduce a breaking change? ``` [ ] Yes [x] No ``` ## Other information thank you to Topher Fangio and Richard Hughes for the original solution
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in validation for the input as a last check as IE interpreted the date '11/14/2016d' as valid which is incorrect.
closes #9994