fix(docs): fix broken links in theming docs #10220

Merged
merged 1 commit into from Jan 4, 2017

Projects

None yet

4 participants

@clshortfuse
Collaborator

Using markdown caused issues with routing.

  • Use ng-href to link to pages

Fixes #10203

@clshortfuse clshortfuse fix(docs): fix broken links in theming docs
Using markdown caused issues with routing.

* Use ng-href to link to pages

Fixes #10203
2f22376
@clshortfuse clshortfuse added this to the 1.1.2 milestone Jan 4, 2017
@googlebot googlebot added the cla: yes label Jan 4, 2017
@topherfangio

LGTM - I don't think there is a way to really "test" it without doing the push, but this is the correct way to fix it.

@@ -43,5 +43,5 @@ Below are usage examples for both the Angular configuration phase, and during ru
})
</hljs>
-For api reference please visit [$mdThemingProvider](/api/service/$mdThemingProvider#enableBrowserColor) documentation.
+For api reference please visit <a ng-href="/api/service/$mdThemingProvider#enableBrowserColor">$mdThemingProvider</a> documentation.
@ThomasBurleson
ThomasBurleson Jan 4, 2017 Contributor

Why are you using ng-href here ?

@clshortfuse
clshortfuse Jan 4, 2017 Collaborator

As with the other link, using markdown syntax returns the wrong URL.

This incorrect behavior was fixed previously in areas of the code, but it seems these two links fell through the cracks.

See 0d7fbad

@ThomasBurleson ThomasBurleson merged commit fd88814 into master Jan 4, 2017

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment