fix(build): prevent closure from stripping $inject annotations #9765

Merged
merged 1 commit into from Oct 27, 2016

Projects

None yet

3 participants

@crisbeto
Member
crisbeto commented Oct 5, 2016

Adds a config that will turn instances of something.$inject into something['$inject'].
This helps in cases where Closure strips the injector due to the object annotation having a @constructor directive.
Note that the regular JS builds have the same output as before.

Fixes #9758.

CC @jelbourn

@crisbeto crisbeto fix(build): prevent closure from stripping $inject annotations
Adds a config that will turn instances of `something.$inject` into `something['$inject']`.
This helps in cases where Closure strips the injector due to the object annotation having a `@constructor` directive.
Note that the regular JS builds have the same output as before.

Fixes #9758.
3256d3e
@crisbeto crisbeto added the type: build label Oct 5, 2016
@ThomasBurleson
Contributor

@jelbourn - please review.

@jelbourn jelbourn merged commit dbc52d0 into angular:master Oct 27, 2016

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment