fix(selection-list): toggle newly-focused item when pressing arrow key + shift #10828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y + shift [Based on the accessibility guidelines](https://www.w3.org/TR/wai-aria-practices-1.1/), multi-select listboxes can support toggling items by pressing the arrow keys + shift. These changes implement the behavior in the selection list.
googlebot
added
the
cla: yes
jelbourn
approved these changes
Apr 13, 2018
| it('should focus and toggle the next item when pressing SHIFT + UP_ARROW', () => { | ||
| const manager = selectionList.componentInstance._keyManager; | ||
| const upKeyEvent = createKeyboardEvent('keydown', UP_ARROW); | ||
| Object.defineProperty(upKeyEvent, 'shiftKey', {get: () => true}); |
There was a problem hiding this comment.
Would it make sense to add a utility function like addModifierKey?
There was a problem hiding this comment.
I suppose, but I think that we should do a larger wrapper around these events that allows you do more stuff (e.g. also dispatching, creating etc).
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the accessibility guidelines, multi-select listboxes can support toggling items by pressing the arrow keys + shift. These changes implement the behavior in the selection list.