New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (invisible) close button to datepicker overlay #14379

Open
jelbourn opened this Issue Dec 4, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@jelbourn
Member

jelbourn commented Dec 4, 2018

The datepicker presents itself as a modal dialog. On mobile devices, scree-reader users don't have an escape button to press and obviously would have a hard time tapping on the backdrop. We can add a close button with cdk-visually-hidden to help work around this. The label for this would also have to be added to MatDatepickerIntl.

@nigel5

This comment has been minimized.

nigel5 commented Dec 6, 2018

Hello, I would like to work on this as my first issue. I am new to working on accessibility.
When the screen reader goes over the button it would announce the function (e.g. "Close") and the user can close the date picker. Is this the desired behavior?

@jelbourn

This comment has been minimized.

Member

jelbourn commented Dec 6, 2018

Yep, that's it. The close button would most likely be the last element in the dialog.

@nigel5

This comment has been minimized.

nigel5 commented Dec 6, 2018

Ok I'm on it. Can you assign this issue to me please.

@jelbourn

This comment has been minimized.

Member

jelbourn commented Dec 6, 2018

Unfortunately github only allows issues to be assigned to team members

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment