Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.3.4 is not a patch #15462

Closed
rcketscientist opened this Issue Mar 13, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@rcketscientist
Copy link

rcketscientist commented Mar 13, 2019

#15134 (comment)

The submitter even noted the breaking nature of the PR, but you pushed it into a patch anyway. Epic!

@crisbeto crisbeto self-assigned this Mar 13, 2019

crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 13, 2019

fix(stepper): avoid breaking change in stepControl type
In angular#15134 we reworked the stepper not to depend on `@angular/forms` under the assumption that our limited `FormControl` interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the `stepControl` type to avoid the breaking change.

Fixes angular#15462.

crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 13, 2019

fix(stepper): avoid breaking change in stepControl type
In angular#15134 we reworked the stepper not to depend on `@angular/forms` under the assumption that our limited `FormControl` interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the `stepControl` type to avoid the breaking change.

Fixes angular#15462.

mmalerba added a commit that referenced this issue Mar 13, 2019

fix(stepper): avoid breaking change in stepControl type
In #15134 we reworked the stepper not to depend on `@angular/forms` under the assumption that our limited `FormControl` interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the `stepControl` type to avoid the breaking change.

Fixes #15462.

mmalerba added a commit that referenced this issue Mar 13, 2019

fix(stepper): avoid breaking change in stepControl type (#15464)
In #15134 we reworked the stepper not to depend on `@angular/forms` under the assumption that our limited `FormControl` interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the `stepControl` type to avoid the breaking change.

Fixes #15462.

mmalerba added a commit that referenced this issue Mar 18, 2019

fix(stepper): avoid breaking change in stepControl type (#15464)
In #15134 we reworked the stepper not to depend on `@angular/forms` under the assumption that our limited `FormControl` interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the `stepControl` type to avoid the breaking change.

Fixes #15462.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.