Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatDialog: "align" attribute appears to not be documented #15482

Closed
jermowery opened this Issue Mar 14, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@jermowery
Copy link

jermowery commented Mar 14, 2019

What is the expected behavior?

That users know they can align the buttons inside of mat-dialog-actions with the "align" attribute

What is the current behavior?

There is no documentation

What are the steps to reproduce?

Go here: https://material.angular.io/components/dialog/overview#dialog-content there is no documentation

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

All

Is there anything else we should know?

I think a blurb should be added indicating that you can use align, I have seen in code people using CSS to do this and it can get messy

@crisbeto crisbeto self-assigned this Mar 15, 2019

crisbeto added a commit to crisbeto/material2 that referenced this issue Mar 15, 2019

docs(dialog): add doc for align attribute
Adds a sentence to the docs about the `align` attribute of the dialog content. We can't document it through doc strings, because it isn't defined in TS.

Fixes angular#15482.

mmalerba added a commit that referenced this issue Mar 15, 2019

docs(dialog): add doc for align attribute (#15500)
Adds a sentence to the docs about the `align` attribute of the dialog content. We can't document it through doc strings, because it isn't defined in TS.

Fixes #15482.

mmalerba added a commit that referenced this issue Mar 18, 2019

docs(dialog): add doc for align attribute (#15500)
Adds a sentence to the docs about the `align` attribute of the dialog content. We can't document it through doc strings, because it isn't defined in TS.

Fixes #15482.

mmalerba added a commit that referenced this issue Mar 18, 2019

docs(dialog): add doc for align attribute (#15500)
Adds a sentence to the docs about the `align` attribute of the dialog content. We can't document it through doc strings, because it isn't defined in TS.

Fixes #15482.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.