fix(form-field): unable to tap on certain types of inputs on iOS #8543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
reviewed
Nov 20, 2017
| &::after { | ||
| content: ' '; | ||
| white-space: pre; | ||
| width: 1px; |
There was a problem hiding this comment.
did you try adding something like margin-left: -1px; just to make extra sure it doesn't mess with the layout, also maybe visibility: hidden;
There was a problem hiding this comment.
I wanted to keep it as minimal as possible. If we added the margin, we'd also have to flip it in RTL. I don't think it's an issue in this case, because users can't type in these input types anyway.
mmalerba
added
pr: lgtm
action: merge
|
@crisbeto please rebase. Thanks! |
crisbeto
force-pushed
the
8001/ios-date-input
branch
from
529c0bc
to
bafe372
Compare
|
Rebased @tinayuangao. |
Fixes an issue that caused certain input types to collapse into 1px tall strips, preventing users from being to tap on them on iOS. Fixes angular#8001.
crisbeto
force-pushed
the
8001/ios-date-input
branch
from
bafe372
to
288238e
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue that caused certain input types to collapse into 1px tall strips, preventing users from being to tap on them on iOS.
Fixes #8001.