New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematics): two consecutive commas generated #14370

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@klemenoslaj
Contributor

klemenoslaj commented Dec 3, 2018

When generating any Material schematic with OnPush changeDetection, we get two consecutive commas in component decorator.

Fixes: #14366

Klemen Oslaj
fix(schematics): two consecutive commas generated
When generating any Material schematic with OnPush changeDetection, we get two consecutive commas in component decorator.

Fixes: #14366

@klemenoslaj klemenoslaj requested review from devversion and jelbourn as code owners Dec 3, 2018

@googlebot

This comment has been minimized.

googlebot commented Dec 3, 2018

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added the cla: no label Dec 3, 2018

@klemenoslaj klemenoslaj closed this Dec 3, 2018

@klemenoslaj klemenoslaj deleted the klemenoslaj:schematics-consecutive-commas branch Dec 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment