New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expansion-panel): add injection token for configuring the default options #14384

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@crisbeto
Member

crisbeto commented Dec 4, 2018

Adds a new injection token to allow people to configure the default options for the expansion panel component.

Fixes #14383.

@crisbeto crisbeto requested review from jelbourn and josephperrott as code owners Dec 4, 2018

@googlebot googlebot added the cla: yes label Dec 4, 2018

@crisbeto crisbeto force-pushed the crisbeto:14383/expansion-default-options branch from b1e655a to 9f92167 Dec 4, 2018

@crisbeto

This comment has been minimized.

Member

crisbeto commented Dec 4, 2018

I don't mind adding some, but it feels like we'd basically be testing DI.

@jelbourn

This comment has been minimized.

Member

jelbourn commented Dec 4, 2018

IMO it's about testing that the panel correctly pulls the default from the custom options

feat(expansion-panel): add injection token for configuring the defaul…
…t options

Adds a new injection token to allow people to configure the default options for the expansion panel component.

Fixes #14383.

@crisbeto crisbeto force-pushed the crisbeto:14383/expansion-default-options branch from 9f92167 to 82ab05f Dec 5, 2018

@crisbeto

This comment has been minimized.

Member

crisbeto commented Dec 5, 2018

@jelbourn I've added a test for the injection token.

@jelbourn

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment