New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): reduce specificity of icon selector #14389

Merged
merged 1 commit into from Dec 5, 2018

Conversation

Projects
None yet
3 participants
@crisbeto
Member

crisbeto commented Dec 5, 2018

In #14161 we had to tweak the selector for an icon inside a mat-menu-item, in order to fix an issue, however the new selector's specificity is a lot higher which can break people's overrides. These changes rework the approach to have a lower specificity selector.

fix(menu): reduce specificity of icon selector
In #14161 we had to tweak the selector for an icon inside a `mat-menu-item`, in order to fix an issue, however the new selector's specificity is a lot higher which can break people's overrides. These changes rework the approach to have a lower specificity selector.

@crisbeto crisbeto requested a review from jelbourn as a code owner Dec 5, 2018

@googlebot googlebot added the cla: yes label Dec 5, 2018

@mmalerba mmalerba merged commit 74e945a into angular:master Dec 5, 2018

1 of 11 checks passed

ci/angular: merge status Status "ci/circleci: tests_local_browsers" is pending, status "ci/circleci: tests_browserstack" is pending, status "ci/circleci: tests_sa...
ci/angular: size Waiting for "ci/circleci: build_release_packages"...
ci/circleci: bazel_build_test CircleCI is running your tests
Details
ci/circleci: build_release_packages CircleCI is running your tests
Details
ci/circleci: e2e_tests CircleCI is running your tests
Details
ci/circleci: lint CircleCI is running your tests
Details
ci/circleci: prerender_build CircleCI is running your tests
Details
ci/circleci: tests_browserstack CircleCI is running your tests
Details
ci/circleci: tests_local_browsers CircleCI is running your tests
Details
ci/circleci: tests_saucelabs CircleCI is running your tests
Details
cla/google All necessary CLAs are signed

mmalerba added a commit that referenced this pull request Dec 5, 2018

mmalerba added a commit that referenced this pull request Dec 5, 2018

Revert "fix(autocomplete): auto-highlighted first option not display …
…correctly if the floating label is disabled" (#14396)

* Revert "fix(drag-drop): error on touch end (#14392)"

This reverts commit 53cecbb.

* Revert "fix(menu): reduce specificity of icon selector (#14389)"

This reverts commit 74e945a.

* Revert "fix(drag-drop): throw better error when attaching to non-element node (#14221)"

This reverts commit 31f0e6d.

* Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (#13774)"

This reverts commit c99c512.

mmalerba added a commit that referenced this pull request Dec 5, 2018

mmalerba added a commit that referenced this pull request Dec 5, 2018

Revert "fix(autocomplete): update template when changing autocomplete…
… in trigger" (#14398)

* Revert "Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled" (#14396)"

This reverts commit aa17fbd.

* Revert "fix(drag-drop): error on touch end (#14392)"

This reverts commit 53cecbb.

* Revert "fix(menu): reduce specificity of icon selector (#14389)"

This reverts commit 74e945a.

* Revert "fix(drag-drop): throw better error when attaching to non-element node (#14221)"

This reverts commit 31f0e6d.

* Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (#13774)"

This reverts commit c99c512.

* Revert "fix(autocomplete): update template when changing autocomplete in trigger (#13814)"

This reverts commit 904a5ea.

mmalerba added a commit that referenced this pull request Dec 10, 2018

fix(menu): reduce specificity of icon selector (#14389)
In #14161 we had to tweak the selector for an icon inside a `mat-menu-item`, in order to fix an issue, however the new selector's specificity is a lot higher which can break people's overrides. These changes rework the approach to have a lower specificity selector.

mmalerba added a commit that referenced this pull request Dec 10, 2018

Revert "fix(autocomplete): auto-highlighted first option not display …
…correctly if the floating label is disabled" (#14396)

* Revert "fix(drag-drop): error on touch end (#14392)"

This reverts commit 53cecbb.

* Revert "fix(menu): reduce specificity of icon selector (#14389)"

This reverts commit 74e945a.

* Revert "fix(drag-drop): throw better error when attaching to non-element node (#14221)"

This reverts commit 31f0e6d.

* Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (#13774)"

This reverts commit c99c512.

mmalerba added a commit that referenced this pull request Dec 10, 2018

Revert "fix(autocomplete): update template when changing autocomplete…
… in trigger" (#14398)

* Revert "Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled" (#14396)"

This reverts commit aa17fbd.

* Revert "fix(drag-drop): error on touch end (#14392)"

This reverts commit 53cecbb.

* Revert "fix(menu): reduce specificity of icon selector (#14389)"

This reverts commit 74e945a.

* Revert "fix(drag-drop): throw better error when attaching to non-element node (#14221)"

This reverts commit 31f0e6d.

* Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (#13774)"

This reverts commit c99c512.

* Revert "fix(autocomplete): update template when changing autocomplete in trigger (#13814)"

This reverts commit 904a5ea.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment