New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: no longer require updating multiple package.json files for bazel #14391

Merged
merged 1 commit into from Dec 6, 2018

Conversation

Projects
None yet
4 participants
@devversion
Member

devversion commented Dec 5, 2018

  • Replaces second "package.json" file with a small workspace that just aliases to the actual dependencies provided in the "@matdeps" workspace. This speeds up the analysis phase and also makes debugging easier.
  • Also proxies the "ng_package" so that it always includes the proper README.md file. Also this means that we can always replace the version placeholders. Similar to angular/angular.

Similar to angular/angular@68074df. Credits to @gregmagolan for this.

We just need a bit more work because we don't overwrite the default compiler, xi18n and packager targets to the actual source files (this is special to Angular because those contain the sources)

@devversion devversion requested review from jelbourn and mmalerba as code owners Dec 5, 2018

@googlebot googlebot added the cla: yes label Dec 5, 2018

@devversion devversion force-pushed the devversion:build/no-longer-require-updating-multiple-package-json-bazel branch from bf0514e to b056693 Dec 5, 2018

@jelbourn

LGTM

@@ -5,6 +5,7 @@ load("//tools:defaults.bzl", "ts_library")
exports_files([
"bazel-tsconfig-build.json",
"bazel-tsconfig-test.json",
"README.md",

This comment has been minimized.

@jelbourn

jelbourn Dec 6, 2018

Member

Not for this PR, but we should create separate npm README files for each of our packages

This comment has been minimized.

@devversion

devversion Dec 6, 2018

Member

Agreed. Should these be pretty much similar to the current one but just have the "correct" package name title and refer to the proper URL for the sources?

This comment has been minimized.

@jelbourn

jelbourn Dec 6, 2018

Member

I created an issue and assigned it to myself for this.

Show resolved Hide resolved tools/npm-workspace/@angular/bazel/bin/BUILD.bazel Outdated
build: no longer require updating multiple package.json files for bazel
* Replaces second "package.json" file with a small workspace that just aliases to the actual dependencies provided in the "@matdeps" workspace. This speeds up the analysis phase and also makes debugging easier.

@devversion devversion force-pushed the devversion:build/no-longer-require-updating-multiple-package-json-bazel branch from b056693 to 3d8e7d5 Dec 6, 2018

@mmalerba mmalerba merged commit 9067fd3 into angular:master Dec 6, 2018

13 checks passed

ci/angular: merge status All checks passed!
ci/angular: size angular_material/material_release_output/material.umd.min.js increased by 342 bytes.
ci/circleci: bazel_build_test Your tests passed on CircleCI!
Details
ci/circleci: build_devapp_aot Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prerender_build Your tests passed on CircleCI!
Details
ci/circleci: publish_snapshots Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment