New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(badge): aria-label not being updated if description changes #14393

Merged
merged 1 commit into from Dec 7, 2018

Conversation

Projects
None yet
4 participants
@crisbeto
Member

crisbeto commented Dec 5, 2018

When we create a new badge element, we set its aria-label to the description of the badge, however that aria-label doesn't update if the description changes. These changes update the label accordingly.

fix(badge): aria-label not being updated if description changes
When we create a new badge element, we set its `aria-label` to the description of the badge, however that `aria-label` doesn't update if the description changes. These changes update the label accordingly.

@crisbeto crisbeto requested a review from jelbourn as a code owner Dec 5, 2018

@googlebot googlebot added the cla: yes label Dec 5, 2018

@jelbourn

LGTM

How do you discover these things?

@crisbeto

This comment has been minimized.

Member

crisbeto commented Dec 6, 2018

I noticed it while looking into a different issue.

@mmalerba mmalerba merged commit ab78183 into angular:master Dec 7, 2018

13 checks passed

ci/angular: merge status All checks passed!
ci/angular: size No baseline available for master / 74e945adc91df1e0328cc5b7ee5992fabb18ca7e
ci/circleci: bazel_build_test Your tests passed on CircleCI!
Details
ci/circleci: build_devapp_aot Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prerender_build Your tests passed on CircleCI!
Details
ci/circleci: publish_snapshots Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed

mmalerba added a commit that referenced this pull request Dec 10, 2018

fix(badge): aria-label not being updated if description changes (#14393)
When we create a new badge element, we set its `aria-label` to the description of the badge, however that `aria-label` doesn't update if the description changes. These changes update the label accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment