New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(autocomplete): update template when changing autocomplete in trigger" #14398

Merged
merged 6 commits into from Dec 5, 2018

Conversation

Projects
None yet
2 participants
@mmalerba
Contributor

mmalerba commented Dec 5, 2018

Reverts #13814

mmalerba added some commits Dec 5, 2018

Revert "Revert "fix(autocomplete): auto-highlighted first option not …
…display correctly if the floating label is disabled" (#14396)"

This reverts commit aa17fbd.
Revert "fix(autocomplete): auto-highlighted first option not display …
…correctly if the floating label is disabled (#13774)"

This reverts commit c99c512.

@mmalerba mmalerba requested a review from crisbeto as a code owner Dec 5, 2018

@googlebot googlebot added the cla: yes label Dec 5, 2018

@mmalerba mmalerba merged commit 63be232 into master Dec 5, 2018

1 of 11 checks passed

ci/angular: merge status Missing required labels: target: *, status "ci/circleci: tests_local_browsers" is pending, status "ci/circleci: build_release_packages" i...
ci/angular: size Waiting for "ci/circleci: build_release_packages"...
ci/circleci: bazel_build_test CircleCI is running your tests
Details
ci/circleci: build_release_packages CircleCI is running your tests
Details
ci/circleci: e2e_tests CircleCI is running your tests
Details
ci/circleci: lint CircleCI is running your tests
Details
ci/circleci: prerender_build CircleCI is running your tests
Details
ci/circleci: tests_browserstack CircleCI is running your tests
Details
ci/circleci: tests_local_browsers CircleCI is running your tests
Details
ci/circleci: tests_saucelabs CircleCI is running your tests
Details
cla/google All necessary CLAs are signed

@mmalerba mmalerba deleted the revert-13814-fix/dynamically-changing-autocomplete branch Dec 10, 2018

mmalerba added a commit that referenced this pull request Dec 10, 2018

Revert "fix(autocomplete): update template when changing autocomplete…
… in trigger" (#14398)

* Revert "Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled" (#14396)"

This reverts commit aa17fbd.

* Revert "fix(drag-drop): error on touch end (#14392)"

This reverts commit 53cecbb.

* Revert "fix(menu): reduce specificity of icon selector (#14389)"

This reverts commit 74e945a.

* Revert "fix(drag-drop): throw better error when attaching to non-element node (#14221)"

This reverts commit 31f0e6d.

* Revert "fix(autocomplete): auto-highlighted first option not display correctly if the floating label is disabled (#13774)"

This reverts commit c99c512.

* Revert "fix(autocomplete): update template when changing autocomplete in trigger (#13814)"

This reverts commit 904a5ea.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment