New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reenable branch-manager #14767

Merged
merged 1 commit into from Jan 9, 2019

Conversation

Projects
None yet
4 participants
@josephperrott
Copy link
Contributor

josephperrott commented Jan 9, 2019

No description provided.

@devversion
Copy link
Member

devversion left a comment

LGTM

@ngbot

This comment has been minimized.

Copy link

ngbot bot commented Jan 9, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: tests_saucelabs" is failing
    pending status "ci/circleci: bazel_build_test" is pending
    pending status "ci/circleci: tests_local_browsers" is pending
    pending status "ci/circleci: tests_browserstack" is pending
    pending status "ci/circleci: build_devapp_aot" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@devversion

This comment has been minimized.

Copy link
Member

devversion commented Jan 9, 2019

Caretaker note: Saucelabs failing because of https://status.saucelabs.com/incidents/y46340ngq3qk, which now results in a lot of PRs acquiring tunnels.

@andrewseguin andrewseguin merged commit 9e74f9d into angular:master Jan 9, 2019

9 of 12 checks passed

ci/angular: merge status Status "ci/circleci: tests_saucelabs" is failing
ci/circleci: tests_browserstack CircleCI is running your tests
Details
ci/circleci: tests_saucelabs CircleCI is running your tests
Details
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build_test Your tests passed on CircleCI!
Details
ci/circleci: build_devapp_aot Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prerender_build Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed

@josephperrott josephperrott deleted the josephperrott:branch-manager branch Jan 9, 2019

andrewseguin added a commit that referenced this pull request Jan 9, 2019

andrewseguin added a commit that referenced this pull request Jan 10, 2019

josephperrott added a commit to josephperrott/material2 that referenced this pull request Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment