New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dialog): support adding and removing classes via dialogRef #14772

Merged
merged 2 commits into from Jan 14, 2019

Conversation

Projects
None yet
5 participants
@willshowell
Copy link
Contributor

willshowell commented Jan 9, 2019

This allows users to add/remove css classes to overlays/dialogs after they've been opened.

Fixes #6206

@willshowell willshowell requested review from crisbeto and jelbourn as code owners Jan 9, 2019

@googlebot googlebot added the cla: yes label Jan 9, 2019

@jelbourn
Copy link
Member

jelbourn left a comment

You'll also need to update the API golds to reflect the new APIs, e.g.:

bazel run //tools/public_api_guard:cdk_overlay_api.accept
Show resolved Hide resolved src/dev-app/dialog/dialog-demo.html Outdated
Show resolved Hide resolved src/cdk/overlay/overlay-ref.ts Outdated

@willshowell willshowell requested a review from devversion as a code owner Jan 9, 2019

@willshowell

This comment has been minimized.

Copy link
Contributor

willshowell commented Jan 9, 2019

@jelbourn done, please take another look

@jelbourn
Copy link
Member

jelbourn left a comment

LGTM

Thanks!

@crisbeto
Copy link
Member

crisbeto left a comment

LGTM

@vivian-hu vivian-hu merged commit b62f3f3 into angular:master Jan 14, 2019

13 checks passed

branch-manager Checked 1 branch — 7.x: success
Details
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build_test Your tests passed on CircleCI!
Details
ci/circleci: build_devapp_aot Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prerender_build Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment