Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dialog): support adding and removing classes via dialogRef #14772

Merged
merged 2 commits into from Jan 14, 2019
Merged

feat(dialog): support adding and removing classes via dialogRef #14772

merged 2 commits into from Jan 14, 2019

Conversation

willshowell
Copy link
Contributor

This allows users to add/remove css classes to overlays/dialogs after they've been opened.

Fixes #6206

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 9, 2019
jelbourn
jelbourn reviewed Jan 9, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to update the API golds to reflect the new APIs, e.g.:

bazel run //tools/public_api_guard:cdk_overlay_api.accept

src/dev-app/dialog/dialog-demo.html Outdated Show resolved Hide resolved
src/cdk/overlay/overlay-ref.ts Outdated Show resolved Hide resolved
@willshowell
Copy link
Contributor Author

@jelbourn done, please take another look

jelbourn
jelbourn approved these changes Jan 10, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks!

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Jan 10, 2019
crisbeto
crisbeto approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vivian-hu-zz vivian-hu-zz merged commit b62f3f3 into angular:master Jan 14, 2019
s2-abdo pushed a commit to s2-abdo/material2 that referenced this pull request Jan 18, 2019
@willshowell @s2-abdo
feat(dialog): support adding and removing classes via dialogRef (angu…
dc3ccbb 
…lar#14772)

* feat(dialog): support adding/removing panelClasses to open dialogRef

Fixes angular#6206

* address comments
s2-abdo pushed a commit to s2-abdo/material2 that referenced this pull request Jan 18, 2019
@willshowell @s2-abdo
feat(dialog): support adding and removing classes via dialogRef (angu…
d55fe98 
…lar#14772)

* feat(dialog): support adding/removing panelClasses to open dialogRef

Fixes angular#6206

* address comments
@julianobrasil julianobrasil mentioned this pull request Jan 30, 2019
Closed
@willshowell willshowell deleted the feat/dialog-classes branch January 30, 2019 22:55
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for hiding a dialog without closing it
5 participants
@willshowell @jelbourn @crisbeto @googlebot @vivian-hu-zz