New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bidi): handle uppercase values correctly #14773

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@crisbeto
Copy link
Member

crisbeto commented Jan 9, 2019

The native dir attribute is case-insensitive, however our dir directive will normalize something like RTL to ltr. These changes account for different cases of the values.

fix(bidi): handle uppercase values correctly
The native `dir` attribute is case-insensitive, however our `dir` directive will normalize something like `RTL` to `ltr`. These changes account for different cases of the values.

@crisbeto crisbeto requested a review from jelbourn as a code owner Jan 9, 2019

@googlebot googlebot added the cla: yes label Jan 9, 2019

@jelbourn
Copy link
Member

jelbourn left a comment

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment