New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix incorrect amd module names #14786

Merged
merged 1 commit into from Jan 11, 2019

Conversation

Projects
None yet
4 participants
@devversion
Copy link
Member

devversion commented Jan 10, 2019

  • Our UMD bundles currently have wrong AMD module names for secondary entry-points which are dash-cased. e.g. AMD module name for the bottom-sheet is @angular/material/bottomSheet.
  • Our UMD bundles currently reference incorrect rollup globals. e.g. the AMD module name is ng.material-experimental.{secondary}, while it should be ng.materialExperimental.

@devversion devversion requested a review from jelbourn as a code owner Jan 10, 2019

@googlebot googlebot added the cla: yes label Jan 10, 2019

@devversion devversion force-pushed the devversion:build/fix-incorrect-amd-module-names branch from fb706bd to e5ef0fc Jan 10, 2019

@devversion devversion force-pushed the devversion:build/fix-incorrect-amd-module-names branch 2 times, most recently from bb5ce06 to 465f2a3 Jan 10, 2019

build: fix incorrect amd module names
* Our UMD bundles currently have wrong AMD module names for secondary entry-points which are dash-cased. e.g. AMD module name for the bottom-sheet is `@angular/material/bottomSheet`.
* Our UMD bundles currently reference incorrect rollup globals. e.g. the AMD module name is `ng.material-experimental.{secondary}`, while it should be `ng.materialExperimental`.

@devversion devversion force-pushed the devversion:build/fix-incorrect-amd-module-names branch from 465f2a3 to 54b4c04 Jan 10, 2019

@jelbourn
Copy link
Member

jelbourn left a comment

LGTM

@andrewseguin andrewseguin merged commit 5d86a1f into angular:master Jan 11, 2019

13 checks passed

branch-manager Checked 1 branch — 7.2.x: success
Details
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build_test Your tests passed on CircleCI!
Details
ci/circleci: build_devapp_aot Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prerender_build Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed

andrewseguin added a commit that referenced this pull request Jan 11, 2019

build: fix incorrect amd module names (#14786)
* Our UMD bundles currently have wrong AMD module names for secondary entry-points which are dash-cased. e.g. AMD module name for the bottom-sheet is `@angular/material/bottomSheet`.
* Our UMD bundles currently reference incorrect rollup globals. e.g. the AMD module name is `ng.material-experimental.{secondary}`, while it should be `ng.materialExperimental`.

josephperrott added a commit to josephperrott/material2 that referenced this pull request Jan 14, 2019

build: fix incorrect amd module names (angular#14786)
* Our UMD bundles currently have wrong AMD module names for secondary entry-points which are dash-cased. e.g. AMD module name for the bottom-sheet is `@angular/material/bottomSheet`.
* Our UMD bundles currently reference incorrect rollup globals. e.g. the AMD module name is `ng.material-experimental.{secondary}`, while it should be `ng.materialExperimental`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment