New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: do not build docs-package bazel targets on circle #14788

Merged
merged 1 commit into from Jan 14, 2019

Conversation

Projects
None yet
4 participants
@devversion
Copy link
Member

devversion commented Jan 10, 2019

  • 74c7681 should have already disabled all docs-package targets on the CI, but apparently bazel test also builds targets which aren't even tests, so we need to filter bazel test as well.
build: do not build docs-package bazel targets on circle
* 74c7681 should have already disabled all `docs-package` targets on the CI, but apparently `bazel test` also builds targets which aren't even tests, so we need to filter `bazel test` as well.

@devversion devversion requested a review from jelbourn as a code owner Jan 10, 2019

@googlebot googlebot added the cla: yes label Jan 10, 2019

@devversion devversion changed the title Build/filter docs package targets for bazel test build: do not build docs-package bazel targets on circle Jan 10, 2019

@devversion

This comment has been minimized.

Copy link
Member

devversion commented Jan 10, 2019

Caretaker note: Branch manager seems to be failing because the 7.2.x branch is not in sync with master.

cc. @josephperrott should we do something about that?

@jelbourn
Copy link
Member

jelbourn left a comment

LGTM

@ngbot

This comment has been minimized.

Copy link

ngbot bot commented Jan 10, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@vivian-hu vivian-hu merged commit e93cc53 into angular:master Jan 14, 2019

13 checks passed

branch-manager Checked 1 branch — 7.2.x: success
Details
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build_test Your tests passed on CircleCI!
Details
ci/circleci: build_devapp_aot Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prerender_build Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment