New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove deprecated Observable.create usages #14789

Merged
merged 1 commit into from Jan 14, 2019

Conversation

Projects
None yet
4 participants
@crisbeto
Copy link
Member

crisbeto commented Jan 10, 2019

Replaces the Observable.create usages by using the Observable constructor directly, because Observable.create is being deprecated in the latest RxJS version.

Fixes #14785.

refactor: remove deprecated Observable.create usages
Replaces the `Observable.create` usages by using the `Observable` constructor directly, because `Observable.create` is being deprecated in the latest RxJS version.

Fixes #14785.
@jelbourn
Copy link
Member

jelbourn left a comment

LGTM

@vivian-hu vivian-hu merged commit d83059b into angular:master Jan 14, 2019

13 checks passed

branch-manager Checked 1 branch — 7.2.x: success
Details
ci/angular: merge status All checks passed!
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build_test Your tests passed on CircleCI!
Details
ci/circleci: build_devapp_aot Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: e2e_tests Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prerender_build Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment