Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepper): avoid breaking change in stepControl type #15464

Merged
merged 1 commit into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@crisbeto
Copy link
Member

crisbeto commented Mar 13, 2019

In #15134 we reworked the stepper not to depend on @angular/forms under the assumption that our limited FormControl interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the stepControl type to avoid the breaking change.

Fixes #15462.

@ngbot

This comment has been minimized.

Copy link

ngbot bot commented Mar 13, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: api_golden_checks" is failing
    pending status "ci/circleci: tests_browserstack" is pending
    pending status "ci/circleci: tests_local_browsers" is pending
    pending status "ci/circleci: tests_saucelabs" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

fix(stepper): avoid breaking change in stepControl type
In #15134 we reworked the stepper not to depend on `@angular/forms` under the assumption that our limited `FormControl` interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the `stepControl` type to avoid the breaking change.

Fixes #15462.

@crisbeto crisbeto force-pushed the crisbeto:15462/stepper-breaking-change branch from ba77f73 to d16d8cf Mar 13, 2019

@mmalerba mmalerba merged commit a146499 into angular:master Mar 13, 2019

10 of 12 checks passed

ci/angular: merge status Status "ci/circleci: tests_browserstack" is failing
ci/circleci: tests_browserstack Your tests failed on CircleCI
Details
branch-manager Checked 1 branch — 7.3.x: success
Details
ci/circleci: api_golden_checks Your tests passed on CircleCI!
Details
ci/circleci: bazel_build_test Your tests passed on CircleCI!
Details
ci/circleci: build_devapp_aot Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prerender_build Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed

mmalerba added a commit that referenced this pull request Mar 18, 2019

fix(stepper): avoid breaking change in stepControl type (#15464)
In #15134 we reworked the stepper not to depend on `@angular/forms` under the assumption that our limited `FormControl` interface would be enough to avoid a breaking change. Some people ended up being broken by the change so this PR reworks the `stepControl` type to avoid the breaking change.

Fixes #15462.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.