Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): render style values in ngOnInit instead of the constructor #15468

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
4 participants
@matsko
Copy link
Member

matsko commented Mar 13, 2019

Due to changes in Angular it's not logical to change style values
directly within a constructor. This should be done instead within
the ngOnInit lifecycle hook.

This patch changes this behavior for the ToolTip component.

@matsko matsko requested a review from andrewseguin as a code owner Mar 13, 2019

@googlebot googlebot added the cla: yes label Mar 13, 2019

@@ -812,7 +812,7 @@ describe('MatTooltip', () => {

describe('special cases', () => {

it('should clear the `user-select` when a tooltip is set on a text field', () => {
fit('should clear the `user-select` when a tooltip is set on a text field', () => {

This comment has been minimized.

@crisbeto

crisbeto Mar 13, 2019

Member

Leftover fit?

@ngbot

This comment has been minimized.

Copy link

ngbot bot commented Mar 13, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: api_golden_checks" is failing
    failure status "ci/circleci: bazel_build_test" is failing
    failure status "ci/circleci: build_release_packages" is failing
    failure status "ci/circleci: e2e_tests" is failing
    failure status "ci/circleci: lint" is failing
    failure status "ci/circleci: prerender_build" is failing
    failure status "ci/circleci: tests_browserstack" is failing
    failure status "ci/circleci: tests_local_browsers" is failing
    failure status "ci/circleci: tests_saucelabs" is failing
    pending missing required labels: target: *

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

fix(tooltip): render style values in ngOnInit instead of the constructor
Due to changes in Angular it's not logical to change style values
directly within a constructor. This should be done instead within
the ngOnInit lifecycle hook.

This patch changes this behavior for the `ToolTip` component.

@matsko matsko force-pushed the matsko:fix_tooltip_ivy branch from 88f2f5c to db6e3e8 Mar 14, 2019

@mmalerba mmalerba merged commit 74583b9 into angular:ivy-2019 Mar 14, 2019

1 of 11 checks passed

ci/angular: merge status Missing required labels: target: *, status "ci/circleci: api_golden_checks" is pending, status "ci/circleci: bazel_build_test" is pending...
ci/circleci: api_golden_checks CircleCI is running your tests
Details
ci/circleci: bazel_build_test CircleCI is running your tests
Details
ci/circleci: build_release_packages CircleCI is running your tests
Details
ci/circleci: e2e_tests CircleCI is running your tests
Details
ci/circleci: lint CircleCI is running your tests
Details
ci/circleci: prerender_build CircleCI is running your tests
Details
ci/circleci: tests_browserstack CircleCI is running your tests
Details
ci/circleci: tests_local_browsers CircleCI is running your tests
Details
ci/circleci: tests_saucelabs CircleCI is running your tests
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.