Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): render style values in ngOnInit instead of the constructor #15469

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
4 participants
@matsko
Copy link
Member

matsko commented Mar 13, 2019

Due to changes in Angular it's not logical to change style values
directly within a constructor. This should be done instead within
the ngOnInit lifecycle hook.

This patch changes this behavior for the ToolTip component.

@matsko matsko requested a review from andrewseguin as a code owner Mar 13, 2019

@googlebot googlebot added the cla: yes label Mar 13, 2019

@mmalerba mmalerba added the P2 label Mar 13, 2019

@crisbeto
Copy link
Member

crisbeto left a comment

LGTM once the CI is sorted out.

@crisbeto crisbeto added the pr: lgtm label Mar 13, 2019

fix(tooltip): render style values in ngOnInit instead of the constructor
Due to changes in Angular it's not logical to change style values
directly within a constructor. This should be done instead within
the ngOnInit lifecycle hook.

This patch changes this behavior for the `ToolTip` component.

@matsko matsko force-pushed the matsko:fix_tooltip_ve branch from 8e37f9e to 5434f07 Mar 13, 2019

@ngbot

This comment has been minimized.

Copy link

ngbot bot commented Mar 13, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: api_golden_checks" is failing
    failure status "ci/circleci: bazel_build_test" is failing
    pending missing required labels: target: *

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba mmalerba merged commit 59818d1 into angular:master Mar 14, 2019

9 of 11 checks passed

ci/angular: merge status Status "ci/circleci: api_golden_checks" is failing, missing required labels: target: *
ci/circleci: api_golden_checks Your tests failed on CircleCI
Details
ci/circleci: bazel_build_test Your tests passed on CircleCI!
Details
ci/circleci: build_devapp_aot Your tests passed on CircleCI!
Details
ci/circleci: build_release_packages Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: prerender_build Your tests passed on CircleCI!
Details
ci/circleci: tests_browserstack Your tests passed on CircleCI!
Details
ci/circleci: tests_local_browsers Your tests passed on CircleCI!
Details
ci/circleci: tests_saucelabs Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.