Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: bazel not working on windows workaround #15484

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@devversion
Copy link
Member

devversion commented Mar 14, 2019

Recently we updated our Bazel setup to Angular V8 beta. With that change
the Sass dependencies took precedence and now fetch the skylib repository
using the git_repository bazel rule. Unfortunately this rule does not always
work as expected in Windows (e.g. when used within Git Bash). Until Bazel
drops the dependency on bash, we should make sure that we fetch skylib
through the http_archive rule (which works on windows). Skylib will be
transitively brought in by the rules_webtesting repository.

build: bazel not working on windows workaround
Recently we updated our Bazel setup to Angular V8 beta. With that change
the Sass dependencies took precedence and now fetch the skylib repository
using the `git_repository` bazel rule. Unfortunately this rule does not always
work as expected in Windows (e.g. when used within Git Bash). Until Bazel
drops the dependency on bash, we should make sure that we fetch skylib
through the `http_archive` rule (which works on windows). Skylib will be
transitively brought in by the `rules_webtesting` repository.
@jelbourn
Copy link
Member

jelbourn left a comment

LGTM

@ngbot

This comment has been minimized.

Copy link

ngbot bot commented Mar 21, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.