Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepper): content not being rendered out initially with ivy #15486

Merged
merged 1 commit into from Mar 14, 2019

Conversation

Projects
None yet
3 participants
@crisbeto
Copy link
Member

crisbeto commented Mar 14, 2019

Equivalent of #15485 for the Ivy branch.

Fixes the stepper's content not being shown on the first render with Ivy, because we assume that the template with be present on init.

fix(stepper): content not being rendered out initially with ivy
Fixes the stepper's content not being shown on the first render with Ivy, because we assume that the template with be present on init.
@ngbot

This comment has been minimized.

Copy link

ngbot bot commented Mar 14, 2019

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: api_golden_checks" is failing
    failure status "ci/circleci: build_release_packages" is failing
    failure status "ci/circleci: e2e_tests" is failing
    failure status "ci/circleci: lint" is failing
    failure status "ci/circleci: prerender_build" is failing
    failure status "ci/circleci: tests_browserstack" is failing
    failure status "ci/circleci: tests_local_browsers" is failing
    failure status "ci/circleci: tests_saucelabs" is failing
    pending missing required labels: target: *
    pending status "ci/circleci: bazel_build_test" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@mmalerba mmalerba merged commit 81d9995 into angular:ivy-2019 Mar 14, 2019

1 of 11 checks passed

ci/angular: merge status Status "ci/circleci: api_golden_checks" is failing, status "ci/circleci: bazel_build_test" is failing, status "ci/circleci: build_release...
ci/circleci: api_golden_checks Your tests failed on CircleCI
Details
ci/circleci: bazel_build_test Your tests failed on CircleCI
Details
ci/circleci: build_release_packages Your tests failed on CircleCI
Details
ci/circleci: e2e_tests Your tests failed on CircleCI
Details
ci/circleci: lint Your tests failed on CircleCI
Details
ci/circleci: prerender_build Your tests failed on CircleCI
Details
ci/circleci: tests_browserstack Your tests failed on CircleCI
Details
ci/circleci: tests_local_browsers Your tests failed on CircleCI
Details
ci/circleci: tests_saucelabs Your tests failed on CircleCI
Details
cla/google All necessary CLAs are signed

crisbeto added a commit to crisbeto/angular that referenced this pull request Mar 14, 2019

test(ivy): update root causes for stepper
Removes the stepper-related tests from the blocklist which were fixed by angular/material2#15486.

matsko added a commit to angular/angular that referenced this pull request Mar 14, 2019

test(ivy): update root causes for stepper (#29314)
Removes the stepper-related tests from the blocklist which were fixed by angular/material2#15486.

PR Close #29314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.