Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(form-field): remove nonbreaking space before * for required fields #15490
The surrounding .mat-form-field-label is already white-space: nowrap so the doesn't serve any
I attempted to use a literal space and not the symbol, but the compiler collapsed it for me.
I tried to add a test to check in a more deliberate way that the spaces were deliberate and there's no real DOM API I found to get the post-collapsing rendered text short of doing a screendiff test. Both innerText and textContent give the spaces pre-collapsing. I did adjust the test to match explicitly literal space and not
I did not add an explicit test that puts a trailing space in the
If you want your PR to be merged, it has to pass all the CI checks.
If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.