refactor(tree): rework to account for ivy changes #15504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworks the `MatTree` and `CdkTree` components to account for some of the changes in Ivy. This includes: * Changing the padding directive to account for a different time at which static inputs are initialized. * Changing the toggle directive to account for inheritance of host listeners working differently. * Switching to `Default` change detection, because the way embedded views are checked is slightly different. * Using `descendants: true` to find the nested node outlet in order to handle a slight difference in how indirect content children are matched.
crisbeto
added
P2
googlebot
added
the
cla: yes
crisbeto
requested review from
andrewseguin,
devversion and
jelbourn
as code owners
crisbeto
removed
the
blocked
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Mar 18, 2019
Removes all of the tests fixed by angular/components#15504 from the blocklist.
matsko
pushed a commit
to angular/angular
that referenced
this pull request
Mar 18, 2019
Removes all of the tests fixed by angular/components#15504 from the blocklist. PR Close #29377
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
Removes all of the tests fixed by angular/components#15504 from the blocklist. PR Close angular#29377
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent of #15503 for the Ivy branch.
Reworks the
MatTreeandCdkTreecomponents to account for some of the changes in Ivy. This includes:Defaultchange detection, because the way embedded views are checked is slightly different.descendants: trueto find the nested node outlet in order to handle a slight difference in how indirect content children are matched.