Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): schematic generates code that throws an exception #15800

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@Splaktar
Copy link
Member

Splaktar commented Apr 11, 2019

fix exception when instantiating MatPaginator before dataSource defined
fix ExpressionChangedAfterItHasBeenCheckedError caused by above

  • first initialize the template w/o dataSource & w/ a sort and paginator
  • then get the references to the template's MatSort and MatPaginator
  • then set the data source's sort and paginator
  • then set the table's data source from the component

Fixes #15788

Not the same issue, but this is also related to #15791.

fix(table): schematic generates code that throws an exception
fix exception when instantiating MatPaginator before dataSource defined
fix ExpressionChangedAfterItHasBeenCheckedError caused by above
- first initialize the template w/o dataSource & w/ a sort and paginator
- then get the references to the template's MatSort and MatPaginator
- then set the data source's sort and paginator
- then set the table's data source from the component

Fixes #15788
@jelbourn

This comment has been minimized.

Copy link
Member

jelbourn commented Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.