Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add linting for class member naming #15812

Open
wants to merge 1 commit into
base: master
from

Conversation

@crisbeto
Copy link
Member

crisbeto commented Apr 13, 2019

Currently we have a convention for prefixing private members with an underscore, however there's nothing verifying it. This comes up occasionally in PRs and there some cases that have deviated from the pattern. These changes add a tslint rule that allows us to customize the naming pattern for the various modifiers.

@googlebot googlebot added the cla: yes label Apr 13, 2019

build: add linting for class member naming
Currently we have a convention for prefixing private members with an underscore, however there's nothing verifying it. This comes up occasionally in PRs and there some cases that have deviated from the pattern. These changes add a tslint rule that allows us to customize the naming pattern for the various modifiers.

@crisbeto crisbeto force-pushed the crisbeto:modifier-pattern-rule branch from 018ddd4 to 7f1d6c2 Apr 13, 2019

@crisbeto crisbeto marked this pull request as ready for review Apr 13, 2019

@mmalerba

This comment has been minimized.

Copy link
Contributor

mmalerba commented Apr 15, 2019

Removed pr: merge safe because while the changes are trivial, they do touch source files that are synced into g3, and should therefore still be presubmitted

@devversion
Copy link
Member

devversion left a comment

LGTM. At some point we should really have something like "Angular TSLint" rules 😄 I could imagine Framework liking this as well :shrug:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.