Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): provide a maximum width #2678

Merged
merged 1 commit into from Jan 18, 2017

Conversation

crisbeto
Copy link
Member

Adds a max-width to the tooltip, in order to wrap longer lines of text. Note that the value is arbitrary since there was nothing about it in the spec.

Fixes #2671.

Adds a `max-width` to the tooltip, in order to wrap longer lines of text. Note that the value is arbitrary since there was nothing about it in the spec.

Fixes angular#2671.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 16, 2017
@david-kerwick
Copy link

Thanks for this. Since it's unspecified would it be worth allowing it to be passed in?

Is it meant to detect the viewport and try not to spill past it using the position strategy?
I still get this if it's at an edge and aligned to bottom, I can now at least move it to the right though.

screen shot 2017-01-17 at 09 05 20

@crisbeto
Copy link
Member Author

I believe that there was another issue about making the tooltip adjust to stay in the viewport. This is mostly to avoid those long lines of text.

@david-kerwick
Copy link

Cheers, I can't seem to find that issue but I'll look out for it

Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 17, 2017
@mmalerba mmalerba merged commit fb5e1d4 into angular:master Jan 18, 2017
kara pushed a commit to kara/material2 that referenced this pull request Jan 20, 2017
Adds a `max-width` to the tooltip, in order to wrap longer lines of text. Note that the value is arbitrary since there was nothing about it in the spec.

Fixes angular#2671.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip expands outside of viewport
5 participants