New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove MaterialModule #6803

Merged
merged 1 commit into from Sep 6, 2017

Conversation

Projects
None yet
6 participants
@josephperrott
Contributor

josephperrott commented Sep 1, 2017

BREAKING CHANGE: MaterialModule will no longer be available.

MaterialModulehas been deprecated since beta.3 and is now being removed.

From beta.3 changelog:

MaterialModule

  • MaterialModule (and MaterialRootModule) have been marked as deprecated.

We've found that, with the current state of tree-shaking in the world,
that using an aggregate NgModule like MaterialModule leads to tools
not being able to eliminate code for components that aren't used.

In order to ensure that users end up with the smallest code size
possible, we're deprecating MaterialModule, to be removed in the a
subsequent release.

To replace MaterialModule, users can create their own "Material"
module within their application (e.g., GmailMaterialModule) that
imports only the set of components actually used in the application.

@josephperrott josephperrott requested a review from jelbourn Sep 1, 2017

@googlebot googlebot added the cla: yes label Sep 1, 2017

@jelbourn

LGTM- can you amend your commit to have a BREAKING CHANGES marker?

@jelbourn jelbourn added the pr: lgtm label Sep 1, 2017

Remove MaterialModule.
BREAKING CHANGE: MaterialModule has been removed and is no longer available.  As noted in the changelog for beta.3, an aggregate module like MaterialModule prevents tools from being able to treeshake unused components and modules.

@tinayuangao tinayuangao merged commit cf1ece0 into angular:master Sep 6, 2017

3 checks passed

Material Payload Size 825.60kb / 1.13kb decrease (ES2015 bundle)
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@josephperrott josephperrott deleted the josephperrott:materialmodule branch Sep 7, 2017

@George35mk

This comment has been minimized.

Show comment
Hide comment
@George35mk

George35mk Sep 27, 2017

and what i need to do now ?? any Help ?? i have error after upgrating to new version "@angular/material": "^2.0.0-beta.11",

George35mk commented Sep 27, 2017

and what i need to do now ?? any Help ?? i have error after upgrating to new version "@angular/material": "^2.0.0-beta.11",

@WindMay

This comment has been minimized.

Show comment
Hide comment
@WindMay

WindMay Sep 29, 2017

@George35mk

and what i need to do now ?? any Help ?? i have error after upgrating to new version "@angular/material": "^2.0.0-beta.11"

Build a like the one that was deleted, but remove the modules that you don't use

cf1ece0

WindMay commented Sep 29, 2017

@George35mk

and what i need to do now ?? any Help ?? i have error after upgrating to new version "@angular/material": "^2.0.0-beta.11"

Build a like the one that was deleted, but remove the modules that you don't use

cf1ece0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment