This repository was archived by the owner on Oct 12, 2021. It is now read-only.
refactor(app-shell): redo project layout, build system, test runner, package layout, and exports #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffbcross
suggested changes
Sep 22, 2016
Contributor
jeffbcross
left a comment
jeffbcross
left a comment
There was a problem hiding this comment.
Looks good! Just a couple of nits, questions and changes.
app-shell/gulpfile.js
Outdated
| }); | ||
|
|
||
| // Trampoline into gulpfile.ts. | ||
| require('./gulpfile.ts'); No newline at end of file |
Contributor
There was a problem hiding this comment.
I recently learned that with ts-node, you don't need this file anymore. You'll have to delete declare var require from gulpfile.ts, but then you can just run gulp build.
| "tslint": "^3.6.0", | ||
| "typescript": "^2.0.2", | ||
| "typings": "^1.0.4" | ||
| "@angular/common": "^2.0.0", |
Contributor
There was a problem hiding this comment.
The Angular, Zone and RxJS dependencies should be peer dependencies in the published package.json. Fine to move them to dev dependencies here though.
Member
Author
There was a problem hiding this comment.
I think @angular/core is the only real peer dep.
app-shell/src/app/index.ts
Outdated
|
|
||
| export * from './module'; | ||
| export * from './prerender'; | ||
| export * from './shell'; |
app-shell/src/app/module.ts
Outdated
| providers: [{provide: IS_PRERENDER, useValue: false}], | ||
| }; | ||
| } | ||
| } No newline at end of file |
app-shell/src/app/prerender.ts
Outdated
| @@ -0,0 +1,3 @@ | |||
| import {OpaqueToken} from '@angular/core'; | |||
|
|
|||
| export const IS_PRERENDER = new OpaqueToken('IsPrerender'); No newline at end of file | |||
app-shell/src/index.ts
Outdated
| @@ -0,0 +1 @@ | |||
| export * from './app'; No newline at end of file | |||
app-shell/tsconfig.es5.json
Outdated
| "src/unit_tests.ts" | ||
| ] | ||
| } | ||
| } |
app-shell/tsconfig.esm.json
Outdated
| "rootDir": ".", | ||
| "baseUrl": ".", | ||
| "paths": { | ||
| "@angular/service-worker/worker": ["src/worker"] |
app-shell/tsconfig.json
Outdated
| "exclude": [ | ||
| "node_modules" | ||
| ] | ||
| } No newline at end of file |
alxhub
force-pushed
the
app-shell-fixes
branch
from
7181131 to
5867cad
Compare
…package layout, and exports Also moves shell-parser to an experimental directory until it can be updated.
alxhub
force-pushed
the
app-shell-fixes
branch
from
5867cad to
ad36aa9
Compare
jeffbcross
approved these changes
Sep 22, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moves shell-parser to an experimental directory until it can be updated.