Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(util): Allow more verbose logging with multiple sessions (#2985). #3499

Merged
merged 3 commits into from Sep 1, 2016

Conversation

heathkit
Copy link
Contributor

No description provided.

@heathkit
Copy link
Contributor Author

Giving this to Craig since he'd like to do more reviews.

@heathkit heathkit assigned cnishina and unassigned sjelin Aug 31, 2016
@@ -200,6 +200,13 @@ exports.config = {
// Use a number less than 1 to denote unlimited. Default is unlimited.
maxSessions: -1,

// Whether or not to buffer output when running tests on multiple browsers
// in parallel. By default, when running multiple browser sessions results
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "By default, when running multiple browser sessions, the results"

@cnishina
Copy link
Member

After these changes are made, LGTM.

@heathkit heathkit merged commit 30102fb into master Sep 1, 2016
@heathkit heathkit deleted the 2985-output-buffering branch September 1, 2016 01:09
@heathkit
Copy link
Contributor Author

heathkit commented Sep 7, 2016

This implements #2985

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants