Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webdriver-manager): use proxy for webdriver-manager #966

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@hankduan
Copy link
Contributor

commented Jun 23, 2014

No description provided.

@hankduan

This comment has been minimized.

Copy link
Contributor Author

commented Jun 23, 2014

I tests against http://www.charlesproxy.com/ already (since I don't have corp proxy), but those who need this feature please try it and let me know if it doesn't work for you.

if (argv.proxy) {
return argv.proxy;
} else if (protocol === 'https:') {
return process.env.HTTPS_PROXY || process.env.HTTP_PROXY;

This comment has been minimized.

Copy link
@juliemr

juliemr Jun 23, 2014

Member

Do we want to support this, or require it to be explicitly entered with --proxy? I haven't had to work behind a corporate proxy, but after a quick search using env.HTTPS_PROXY doesn't seem to be a common pattern.

This comment has been minimized.

Copy link
@juliemr

juliemr Jun 23, 2014

Member

responding to myself. Looked around, did find a couple uses of this, so let's keep it.

@juliemr

This comment has been minimized.

Copy link
Member

commented Jun 23, 2014

LGTM

@hankduan

This comment has been minimized.

Copy link
Contributor Author

commented Jun 23, 2014

merged with 6906c93

@nwinkler

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2014

I've made a couple of minor modifications here: #968

The error handling for the request was not evaluating the error variable, thus silently swallowing any errors coming from the request module.

I also added support for both lower case and upper case environment variables, i.e. (HTTPS_PROXY and https_proxy). This is in line with what tools like npm use.

@hankduan hankduan deleted the hankduan:proxy branch Oct 6, 2014

@katlimruiz

This comment has been minimized.

Copy link

commented Dec 4, 2015

at first it didnt work for me.
How to solve? Set env variables as below:
$ set HTTP_PROXY=http://proxy.com:8080
$ set HTTPS_PROXY=http://proxy.com:8080
and then run your command
(in my case it was due to angular-seed, so when bower install ran, it picked up these variables)

@ericis

This comment has been minimized.

Copy link

commented Jun 27, 2018

Doesn't work for a couple of us. We tried HTTP_PROXY and HTTPS_PROXY and setting node config proxy and still get the error: Error: tunneling socket could not be established, cause=getaddrinfo ENOTFOUND 9091 9091:80. Other internet commands are working with the above proxy settings correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.