Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

feat(router): allow not leaving when only params change #25

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Member

vicb commented Mar 6, 2014

fix #1

I've done some changes in addition to only the bug fix, let me know if this is ok (which I hope) or if you prefer to see different commits.

@vicb vicb commented on the diff Mar 6, 2014

lib/client.dart
if (treePath.isEmpty) return new Future.value(true);
+
@vicb

vicb Mar 6, 2014

Member

"real" change starting here

Member

pavelgj commented Apr 3, 2014

I would appreciate if you did split cleanup and feature changes into separate PRs. Thanks.

Member

vicb commented Apr 3, 2014

I'll do different commit next time, sorry for that.

As I should probably rebase this, I can take care of splitting commits at the same time ?

@vicb vicb closed this Apr 3, 2014

@vicb vicb referenced this pull request Apr 4, 2014

Closed

Improve perf + code cleanup #32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment