Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SystemJS support #283

Closed
jeffwhelpley opened this issue Feb 24, 2016 · 18 comments
Closed

SystemJS support #283

jeffwhelpley opened this issue Feb 24, 2016 · 18 comments

Comments

@jeffwhelpley
Copy link
Contributor

@jeffwhelpley jeffwhelpley commented Feb 24, 2016

Right now Universal does not work with SystemJS. Need to do some research here to find the root cause.

@wesleycho
Copy link
Contributor

@wesleycho wesleycho commented Feb 26, 2016

I'll take a look at this

@manekinekko
Copy link
Member

@manekinekko manekinekko commented Feb 28, 2016

@jeffwhelpley @wesleycho this may be related...

Last week, I started a side POC getting universal run on Java 8 Nashorn. And I discovered that SystemJS is not supported on Nashorn. I opened an issue for that.
See it here: systemjs/systemjs#1113

@guybedford
Copy link

@guybedford guybedford commented Mar 7, 2016

Just let me know if I can help here at all as well. Conditional package loading in SystemJS may come in handy here too.

@sullivanpt
Copy link

@sullivanpt sullivanpt commented May 9, 2016

This issue description is vague, but I can say I had universal running against systemjs (without jspm) in the past https://github.com/sullivanpt/ng2-universal-seed/tree/systemjs. (I abandoned the branch because webpack/browserify gave a more consistent dependency experience on express.)

@jeffwhelpley
Copy link
Contributor Author

@jeffwhelpley jeffwhelpley commented May 9, 2016

Thanks for the feedback @sullivanpt. Hey, @gdi2290 and @manekinekko what were the issues you guys ran into with this?

@Codenator81
Copy link

@Codenator81 Codenator81 commented May 14, 2016

@jeffwhelpley First when I use systemjs-builder and in systemjs.config.js

//...
var map = {
        'root':                       '',  
        'app':                        'app', // 'dist',
        'rxjs':                       'node_modules/rxjs',
        '@angular':                   'node_modules/@angular',
        'angular2-universal':         'node_modules/angular2-universal/browser.js',
        'angular2-universal-polyfills': 'node_modules/angular2-universal/dist/polyfills.js'
    };
//...

and import bootstrap

import {bootstrap} from 'angular2-universal';

have error

Build error
{ Error on fetch for node_modules/angular2-universal/dist/common.js at file:///Users/alex/Sites/ng2/sampleTSexpress/universal-systemjs/node_modules/angular2-universal/dist/common.js
        Loading node_modules/angular2-universal/dist/browser/browser.js
        Loading node_modules/angular2-universal/browser.js
        Loading dist/client.js
        Error: ENOENT: no such file or directory, open '/Users/alex/Sites/ng2/sampleTSexpress/universal-systemjs/node_modules/angular2-universal/dist/common.js'
    at Error (native)
  originalErr: 
   { Error: ENOENT: no such file or directory, open '/Users/alex/Sites/ng2/sampleTSexpress/universal-systemjs/node_modules/angular2-universal/dist/common.js'
       at Error (native)
     errno: -2,
     code: 'ENOENT',
     syscall: 'open',
     path: '/Users/alex/Sites/ng2/sampleTSexpress/universal-systemjs/node_modules/angular2-universal/dist/common.js' } }

when build

@guybedford
Copy link

@guybedford guybedford commented May 15, 2016

The above sounds like a standard Node compatibility problem - trying to load ../common as a directory require in Node through SystemJS when what is expected by SystemJS is ../common/index.js.

Alternatively this project could rewrite the require('../common') in dist/browser/browser.js to require('../common/index.js') and not explicitly rely on the directory require resolution.

@kukjevov
Copy link

@kukjevov kukjevov commented Sep 10, 2016

Is there any progress on this? Is there any plan when this will be ready for use? Do you think that SystemJs will be usable with asp.net core server side?

Thank you

@jeffwhelpley
Copy link
Contributor Author

@jeffwhelpley jeffwhelpley commented Sep 10, 2016

Hi, @kukjevov, so this is still very high on our list, but it is currently not on the critical path for the full release. We have a couple high priority bugs and upgrades we are focused on now. Of course, if anyone from the community wants to help on this, please let @gdi2290 and I know and we can provide some guidance. Otherwise this will be a post-release item.

@PatrickJS PatrickJS removed this from the Beta.0 milestone Sep 10, 2016
@MarkPieszak
Copy link
Member

@MarkPieszak MarkPieszak commented Sep 11, 2016

@kukjevov There's a great webpack starter with .NET Core, any reason you want to use System? Just curious!

@kuldeepkeshwar
Copy link

@kuldeepkeshwar kuldeepkeshwar commented Sep 11, 2016

@kukjevov
@MarkPieszak is right
it's easy to use and it's a more mature technology compared to its closest competitor, SystemJS.

@kukjevov
Copy link

@kukjevov kukjevov commented Sep 11, 2016

Hi all :).

Thank you very much for answers. I know that there is Webpack already prepared for usage with .NET Core. My reason is simple, right now im using SystemJS and currently dont have time to study WebPack in the first, but dont think this could be problem but dont have time to update project for WebPack.

Still im missing a bit documentation for Universal, when im using something i need to know how it works, not in detail but currently i dont see anywhere how is "index.html" loaded on server side.

But im already thinking about migrating to WebPack.
Anyway thx for replies :)

@PatrickJS
Copy link
Member

@PatrickJS PatrickJS commented Oct 13, 2016

I'm going to close this until someone from the community creates a PR to own support of SystemJS

@NiklasRaab
Copy link

@NiklasRaab NiklasRaab commented Mar 9, 2017

Please provide support for systemjs!

@PatrickJS
Copy link
Member

@PatrickJS PatrickJS commented Mar 9, 2017

universal is merging into core which means it has support in Angular 4+

@NiklasRaab
Copy link

@NiklasRaab NiklasRaab commented Mar 9, 2017

Love you! Thats properbly the fastest answer i've ever get 👍

@PatrickJS
Copy link
Member

@PatrickJS PatrickJS commented Mar 9, 2017

no problem 👍

@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Sep 4, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet