Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(common): move CommonEngine into its own entry point #1010

Merged
merged 3 commits into from Jun 9, 2018

Conversation

Toxicable
Copy link

Common engine would have been pulled down to the client side.
This ensures it wont be

@Toxicable Toxicable changed the title Fabian/common engine entry refactor(common): move CommonEngine into its own entry point Jun 9, 2018
Copy link
Member

@CaerusKaru CaerusKaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaerusKaru CaerusKaru merged commit cbe24c9 into master Jun 9, 2018
@CaerusKaru CaerusKaru deleted the fabian/common-engine-entry branch June 9, 2018 04:31
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants