fix(platform-node): 2.1.1 fix - update private imports and make backwards compatible #607
Conversation
Fixes #606 SelectorMatcher & CssSelector made public. ViewUtils changed to view_utils Backwards compatibility
@@ -16,18 +18,24 @@ const { | |||
} = __platform_browser_private__; | |||
|
|||
const { | |||
ViewUtils, | |||
view_utils, |
PatrickJS
Oct 24, 2016
Member
this also needs to be backwards compatible
this also needs to be backwards compatible
Anything new regarding this issue? |
@gdi2290 want me to refactor this more in your way? |
Angular2 在 asp.net core 里面只能这样使用? 不能官方原生态使用? Angular2 in asp.net core which can only be used? Can not the official use of the original ecology? |
Any update, not seeing the fix applied. The latest npm version is 2.1.0-rc.1 |
@SamD @julienR2 I believe we need to wait for Core to make these changes, but in the meantime if you want to use 2.1.1+ you can use the |
Thanks a lot for the workaround ! I missed it during my investigations.. Not in a hurry for 2.1.1+ so far, but I keep it close in case I need a feature from this version until Core changes :) |
@MarkPieszak I tried this workaround with 2.2.0, but it doesn't seem to do the trick. Should it work with 2.2.0 as well? |
@larsbeck use the workaround fix here (https://github.com/MarkPieszak/aspnetcore-angular2-universal/tree/master/Client) take the
|
@MarkPieszak Ah yes, moving them to the very top fixed it. Thanks! |
this gets really tricky to support semver. It's best just to follow the angular releases for at least the major and minor releases while the patches we can release out of sync |
Is there anything new regarding this PR? |
will be fixed in ng4 |
People who are planning to import "import './__2.1.1.workaround.ts'; " need to take care of the order as well. |
Yes @sohaibjaved44 typically you want it below the universal polyfills, otherwise some bizarre errors pop up. |
@MarkPieszak and @sohaibjaved44 thank you! This fixed something that's been confusing me for hours. I think I was confused because of this comment. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #606
SelectorMatcher & CssSelector made public.
ViewUtils changed to view_utils
Backwards compatibility