From 7f8ce7fc390480da53f5c905c0851d8b331fc0c4 Mon Sep 17 00:00:00 2001 From: Cameron Steffen Date: Mon, 15 Apr 2019 18:50:54 -0500 Subject: [PATCH] add super.dispose() --- angular_components/lib/model/selection/selection_options.dart | 2 ++ .../lib/src/model/selection/stream_selection_options_impl.dart | 1 + 2 files changed, 3 insertions(+) diff --git a/angular_components/lib/model/selection/selection_options.dart b/angular_components/lib/model/selection/selection_options.dart index 94b61ac1b..61bee41a5 100644 --- a/angular_components/lib/model/selection/selection_options.dart +++ b/angular_components/lib/model/selection/selection_options.dart @@ -9,6 +9,7 @@ import 'dart:async'; import 'package:angular_components/model/collection/labeled_list.dart'; import 'package:angular_components/model/observable/observable.dart'; import 'package:angular_components/utils/disposer/disposer.dart'; +import 'package:meta/meta.dart'; export 'package:angular_components/src/model/selection/delegating_selection_options.dart'; @@ -144,6 +145,7 @@ class SelectionOptions extends GroupedOptions optionGroups = newOptions; } + @mustCallSuper @override void dispose() { _controller.close(); diff --git a/angular_components/lib/src/model/selection/stream_selection_options_impl.dart b/angular_components/lib/src/model/selection/stream_selection_options_impl.dart index bb1f884d5..88b50ebab 100644 --- a/angular_components/lib/src/model/selection/stream_selection_options_impl.dart +++ b/angular_components/lib/src/model/selection/stream_selection_options_impl.dart @@ -14,5 +14,6 @@ class _StreamSelectionOptions extends SelectionOptions { @override void dispose() { _streamSub?.cancel(); + super.dispose(); } }